RustyStriker/Klooni1010
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Don't hardcode effect names on two different places

Browse source
This commit is contained in:
Lonami Exo 2017-09-09 18:40:43 +02:00
parent df0741567c
commit f718db851c
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
core/src/io/github/lonamiwebs/klooni/Effect.java
View file

@ -106,10 +106,10 @@ public class Effect {
// String comparision is more expensive compared to a single integer one, // String comparision is more expensive compared to a single integer one,
// and when creating instances of a lot of effects it's better if we can // and when creating instances of a lot of effects it's better if we can
// save some processor cycles. // save some processor cycles.
if (name.equals("vanish")) return 0; final Effect[] effects = getEffects();
if (name.equals("waterdrop")) return 1; for (int i = 0; i != effects.length; ++i)
if (name.equals("evaporate")) return 2; if (effects[i].name.equals(name))
if (name.equals("spin")) return 3; return i;
return -1; return -1;
} }