assets/web/index.html

@@ -13,6 +13,8 @@
             function init() {
                 let view = document.getElementById('game-view'); 
                 view.onwheel = onGameViewScroll;
+                view.onclick = (e) => console.log('click', e);
+                view.onauxclick = (e) => console.log(e);
                 view.onmousemove = onGameMouseMove;
                 view.onmouseup = onGameMouseUp;
                 view.oncontextmenu = () => false;
@@ -71,7 +73,7 @@
                 </p>
                 <hr style='width: 75%;' />
                 <p style='margin: 4px 2px;'>
-                    ${m.text.replace('\n', '\n<br>\n')}
+                    ${m.text}
                 </p>
                 `
                 msg.oncontextmenu = (e) => { 
@@ -82,21 +84,6 @@
                     cm.style.left = `${e.pageX}px`;
                 	return false;
                 }
-                if(m.actions) {
-                    let holder = document.createElement('div');
-                    holder.style.display = 'flex';
-                    holder.style.flexWrap = 'wrap';
-                    msg.appendChild(holder);
-                    for (const act of m.actions) {
-                        let button = document.createElement('button');
-                        button.innerText = act.display_name ?? act.name;
-                        button.action = act;
-                        button.onclick = () => console.log(button.action);
-                        button.style.margin = '2px';
-                        button.onclick = () => openRollsPopup(act);
-                        holder.appendChild(button);
-                    }
-                }
                 let history = document.getElementById('chat-history');
                 // this is to force update everytime we get a duplicate msg to allow msg editing (yay)
                 let exists = Array.from(history.children).filter(e => e.style.order == m.id)[0];
@@ -124,7 +111,7 @@
                     draggedToken.offY = ((e.clientY - mapOffsetY) / mapScale) - parseInt(token.style.top);
                     token.children[0].style.cursor = 'grabbing';
                 }
-                map.appendChild(token);
+                map.append(token);
             }
             tavern.onmovetoken = (m) => {
                 let token = Array.from(document.getElementsByClassName('token')).filter(t => t.token_id == m.token_id)[0]
@@ -161,6 +148,7 @@
                 else if(draggedToken.token != null && event.buttons == 1) { 
                     let top = (event.clientY - mapOffsetY) / mapScale - draggedToken.offY;
                     let left = (event.clientX - mapOffsetX) / mapScale - draggedToken.offX;
+                    console.log(event.clientX, event.clientY, draggedToken.offX, draggedToken.offY);
                     draggedToken.token.style.top = `${top}px`;
                     draggedToken.token.style.left = `${left}px`;
                 }
@@ -184,61 +172,6 @@
                 tb.value = '';
                 tavern.simple_msg(text);
             }
-            function openRollsPopup(action) {
-                let holder = document.getElementById('dice-roll-holder');
-                holder.innerHTML = ''; // remove all holder children
-                holder.action = action;
-                if(action.rolls != undefined && Array.isArray(action.rolls)) {
-                    for (const r of action.rolls) {
-                        // name (extra)     (dice_amount)d(dice_type) + constant | enabled
-                        console.log(r);
-                        let row = document.createElement('div');
-                        row.style.display = 'flex';
-                        row.roll = r;
-                        row.innerHTML = `
-                        <p style='flex-grow: 1;'>${r.name} ${r.extra != null ? '(' + r.extra + ')' : ''}</p>
-                        <p style='margin-right: 8px;'>${r.dice_amount}d${r.dice_type} + ${r.constant}</p>
-                        <input type='checkbox' ${r.enabled ? 'checked' : ''} />
-                        `;
-                        holder.appendChild(row);
-                    }
-                }
-                document.getElementById('dice-roll-title').innerText = action.display_name ?? action.display;
-                document.getElementById('dice-roll-popup').style.display = 'flex';
-            }
-            function rollPopup() {
-                // TODO: Maybe let the server roll the dice?
-                // first - hide the popup
-                document.getElementById('dice-roll-popup').style.display = 'none';
-                // get the holder and start rolling dice
-                let rolls = [];
-                let holder = document.getElementById('dice-roll-holder');
-                for(const h of holder.children) {
-                    if(h.roll && h.children[2].checked) {
-                        let roll = { name: h.roll.name, extra: h.roll.extra };
-                        let msg = '';
-                        let sum = 0;
-                        for (let i = 0; i < h.roll.dice_amount; i++) {
-                            // Math.random gives a value in [0, 1), so we need to add 1 at the end      
-                            let roll = Math.floor(Math.random() * h.roll.dice_type) + 1;
-                            sum += roll;
-                            msg += `${roll}`;
-                            if(i != h.roll.dice_amount - 1 || h.roll.constant != 0) {
-                                msg += ' + ';
-                            }
-                        }
-                        if(h.roll.constant != 0) {
-                            sum += h.roll.constant;                        
-                            msg += `${h.roll.constant}`;
-                        }
-                        roll.result = sum;
-                        roll.result_text = msg;
-                        rolls.push(roll);
-                    }
-                }
-                console.log(rolls);
-                tavern.action_result(holder.action.name, 'Louise', [], rolls);
-            }
         </script>
         <style>
             html, body {
@@ -345,22 +278,6 @@
                 <div style="position:absolute; top: 10px; left: 5px; background-color: rgb(255, 166, 0); z-index: 1;" >
                     floating<br>stuff
                 </div>
-                <div id="dice-roll-popup" style="display:none; justify-content: center; width: 100%; height: 100%; background-color: transparent; position: absolute; z-index: 2; top: 0px; left: 0px">
-                    <div style="display:flex; width: 50%; justify-content: center; flex-direction: column;">
-                        <div style="display: flex; height: fit-content; flex-direction: column; background-color: #ffffd6; color: black; border: black solid 1px; padding: 8px; border-radius: 8px;">
-                            <h3 id="dice-roll-title" style="align-self: center;">
-                                THIS IS THE ROLL DISPLAY
-                            </h3>
-                            <div id="dice-roll-holder" style="display: flex; flex-direction: column;">
-
-                            </div>
-                            <div style="display: flex;">
-                                <button style="flex-grow: 1; margin: 4px;" onclick="document.getElementById('dice-roll-popup').style.display = 'none';">Cancel</button>
-                                <button style="flex-grow: 1; margin: 4px;" onclick="rollPopup()">Roll</button>
-                            </div>
-                        </div>
-                    </div>
-                </div>
                 <div id="map" style="position:absolute; transform-origin: top left;">
                     <img src="https://rustystriker.dev/molly.jpg" height="200%" >
                 </div>

assets/web/socket.js

@@ -87,7 +87,3 @@ tavern.move_token = (id, x, y) => {
 	if(!tavern.connected || tavern.loggedIn) { return false; }
 	tavern.socket.send(JSON.stringify({ move_token: { token_id: id, x: x, y: y }  }));
 }
-tavern.action_result = (name, source, targets, results) => {
-	if(!tavern.connected || tavern.loggedIn) { return false; }
-	tavern.socket.send(JSON.stringify({ action_result: { name: name, source: source ?? '', targets: targets ?? [], results: results }  }));
-}

readme.md

@@ -3,7 +3,7 @@
 ## Client todo
 
 [ ] implement tavern functions
-[x] token drag & drop
+[ ] token drag & drop
 [ ] Chat
     [x] Send new chat messages
     [x] recv new chat messages

src/api/mod.rs

@@ -5,28 +5,23 @@ pub mod map_actions;
 use game_actions::SpawnToken;
 use serde::{Deserialize, Serialize};
 
-use crate::game::{chat_message::ChatMessage, entry::ActionResult};
+use crate::game::chat_message::ChatMessage;
 
 #[derive(Serialize, Deserialize, Default, Debug)]
 #[serde(rename_all = "snake_case")]
 pub enum Request {
     #[default]
     Error,
-    // Connection requests 
     Login(login::LoginRequest),
-    Quit,
-    Kick(String),
-    Shutdown,
-    // Chat requests
     Message(ChatMessage),
     GetChatHistory { amount: usize, from: usize },
     GetLastMessages { amount: usize, },
-    // Map requests
     GetTokens,
     SpawnToken { x: i32, y: i32, img_path: String },
     MoveToken { token_id: usize, x: i32, y: i32 },
-    // Actions requests
-    ActionResult(ActionResult)
+    Quit,
+    Kick(String),
+    Shutdown
 }
 #[derive(Serialize, Clone, Debug)]
 #[serde(rename_all = "snake_case")]

src/game/chat_message.rs

@@ -1,7 +1,5 @@
 use serde::{Deserialize, Serialize};
 
-use super::entry::ActionDefinition;
-
 
 #[derive(Serialize, Deserialize, Debug, Clone, Default)]
 pub struct ChatMessage {
@@ -14,10 +12,12 @@ pub struct ChatMessage {
     pub character: Option<String>,
     /// whisper item
     pub whisper: Option<String>,
-    /// If the originating action had a dice roll with a DC (or similar), an option to show if the action roll succeeded
-    pub success: Option<bool>,
+    /// Rolls of the action, if not empty a roll should happen before
+    pub roll: Option<Vec<RollDialogOption>>,
+    /// Optional roll target
+    pub roll_target: Option<i32>,
     /// Optional action buttons, for a chat message this will be empty
-    pub actions: Option<Vec<ActionDefinition>>,
+    pub actions: Option<Vec<String>>,
     /// Targets of the action, for a chat message this will be empty
     pub targets: Option<Vec<String>>,
     /// message id, should be left emitted or 0 for new messages
@@ -35,10 +35,6 @@ impl ChatMessage {
             text, ..Default::default()
         }
     }
-    pub fn character(mut self, character: Option<String>) -> Self {
-        self.character = character;
-        self
-    }
     pub fn source(mut self, source: String) -> Self {
         self.source = source;
         self
@@ -49,17 +45,31 @@ impl ChatMessage {
         self
     }
     /// sets the roll value for the message (chaining multiple will override each other) 
-    pub fn success(mut self, success: Option<bool>) -> Self {
-        self.success = success;
+    pub fn roll(mut self, roll: Option<Vec<RollDialogOption>>) -> Self {
+        self.roll = roll;
+        self
+    }
+    /// adds a single roll to the message (chaining multiple will add multiple rolls)
+    pub fn with_roll(mut self, roll: RollDialogOption) -> Self {
+        if let Some(rs) = &mut self.roll {
+            rs.push(roll);
+        }
+        else {
+            self.roll = Some(vec![roll]);
+        }
+        self
+    }
+    pub fn roll_target(mut self, target: Option<i32>) -> Self {
+        self.roll_target = target;
         self
     }
     /// sets the actions value (chaining multiple will override)
-    pub fn actions(mut self, actions: Option<Vec<ActionDefinition>>) -> Self {
+    pub fn actions(mut self, actions: Option<Vec<String>>) -> Self {
         self.actions = actions;
         self
     }
     /// adds a single action to the message (chaining  multiple will add multiple actions)
-    pub fn with_action(mut self, action: ActionDefinition) -> Self {
+    pub fn with_action(mut self, action: String) -> Self {
         if let Some(acts) = &mut self.actions {
             acts.push(action);
         }
@@ -94,3 +104,19 @@ impl ChatMessage {
 }
 
 fn default_id() -> usize { 0 }
+
+#[derive(Serialize, Deserialize, Debug, Clone)]
+pub struct RollDialogOption {
+    /// Field name
+    pub name: String,
+    /// dice size (aka d6, d12, d20)
+    pub dice_type: u16,
+    /// amount of dice (aka 1d6, 2d12, 10d20)
+    pub dice_amount: u16,
+    /// Constant amout to add (+7, +3, -1)
+    pub constant: i16,
+    /// Extra data, like damage type
+    pub extra: String,
+    /// should be enabled by default
+    pub enabled: bool
+}

src/game/entry.rs

@@ -1,4 +1,4 @@
-use serde::{Deserialize, Serialize};
+use serde::Serialize;
 
 use super::chat_message::ChatMessage;
 
@@ -23,93 +23,13 @@ pub trait GameEntry : Serialize + Sized {
     fn to_chat(&self) -> ChatMessage;
 }
 
-#[derive(Serialize, Deserialize, Debug, Clone, Default)]
 pub struct ActionDefinition {
     pub name: String,
-    pub display_name: Option<String>,
-    pub source: Option<String>,
     pub targets: i32,
-    pub rolls: Option<Vec<DiceRoll>>,
-}
-impl ActionDefinition {
-    pub fn new(name: String) -> Self {
-        Self {
-            name, ..Default::default()
-        }
-    }
-    pub fn display_name(mut self, name: Option<String>) -> Self {
-        self.display_name = name;
-        self
-    }
-    pub fn source(mut self, source: Option<String>) -> Self {
-        self.source = source;
-        self
-    }
-    pub fn targets(mut self, targets: i32) -> Self {
-        self.targets = targets;
-        self
-    }
-    pub fn rolls(mut self, rolls: Option<Vec<DiceRoll>>) -> Self {
-        self.rolls = rolls;
-        self
-    }
-    pub fn with_roll(mut self, roll: DiceRoll) -> Self {
-        if let Some(rolls) = &mut self.rolls {
-            rolls.push(roll);
-        }
-        else {
-            self.rolls = Some(vec![roll]);
-        }
-        self
-    }
 }
 
-#[derive(Serialize, Deserialize, Debug, Clone)]
 pub struct ActionResult {
     pub name: String,
-    pub source: String,
-    pub targets: Vec<String>,
-    pub results: Vec<DiceRollResult>,
-}
-
-#[derive(Serialize, Deserialize, Debug, Clone, Default)]
-pub struct DiceRoll {
-    /// Field name
-    pub name: String,
-    /// dice size (aka d6, d12, d20)
-    pub dice_type: u16,
-    /// amount of dice (aka 1d6, 2d12, 10d20)
-    pub dice_amount: u16,
-    /// Constant amout to add (+7, +3, -1)
-    pub constant: i16,
-    /// should be enabled by default
-    pub enabled: bool,
-    /// Extra data, like damage type
-    pub extra: Option<String>,
-}
-impl DiceRoll {
-    pub fn new(name: String, dice_type: u16, dice_amount: u16) -> Self {
-        Self {
-            name, dice_type, dice_amount, enabled: true, ..Default::default()
-        }
-    }
-    pub fn constant(mut self, constant: i16) -> Self {
-        self.constant = constant;
-        self
-    }
-    pub fn enabled(mut self, enabled: bool) -> Self {
-        self.enabled = enabled;
-        self
-    }
-    pub fn extra(mut self, extra: Option<String>) -> Self {
-        self.extra = extra;
-        self
-    }
-}
-#[derive(Serialize, Deserialize, Debug, Clone)]
-pub struct DiceRollResult {
-    pub name: String,
-    pub result: i32,
-    pub result_text: String,
-    pub extra: Option<String>,
+    pub roll_result: i32,
+    pub roll_target: i32,
 }

src/lib.rs

@@ -1,5 +1,5 @@
 use api::game_actions::SpawnToken;
-use game::{chat_message::ChatMessage, entry::{ActionDefinition, DiceRoll}, Game, GameImpl};
+use game::{chat_message::ChatMessage, Game, GameImpl};
 use tokio::sync::{broadcast, mpsc};
 
 pub mod api;
@@ -18,22 +18,7 @@ impl GameServer {
         Self {
             _game: Game::new(),
             tokens: vec![("assets/pf2r/tokens/louise.jpg".to_string(), 2, 2)],
-            chat: vec![
-                (
-                    "Server".to_string(), 
-                    ChatMessage::new("a weapon description".to_string())
-                        .id(1)
-                        .character(Some("Sword or something".to_string()))
-                        .with_action(
-                            ActionDefinition::new("weapon/attack".to_string())
-                            .display_name(Some("Attack +7".to_string()))
-                            .with_roll(DiceRoll::new("Pierce".to_string(), 12, 1).constant(1))
-                            .with_roll(DiceRoll::new("Fire".to_string(), 4, 2))
-                        )
-                        .with_action(ActionDefinition::new("Attack +3".to_string()))
-                        .with_action(ActionDefinition::new("Attack -1".to_string()))
-                )
-            ],
+            chat: Vec::new(),
         }
     }
 
@@ -91,7 +76,7 @@ impl GameServer {
                         amount = self.chat.len();
                     }
                     let start = if amount >= self.chat.len() {
-                        0
+                        self.chat.len()
                     } else {
                         self.chat.len() - amount
                     };
@@ -121,20 +106,6 @@ impl GameServer {
                         _ = broadcast.send((None, api::Response::MoveToken { token_id, x, y }));
                     }
                 },
-                api::Request::ActionResult(result) => {
-                    let msg = ChatMessage::new(
-                        result.results.iter()
-                            // .map(|d| &d.result_text)
-                            .fold(String::new(), |a,b| a + &format!("{}: {} = {}\n", &b.name, &b.result_text, b.result))
-                        )
-                        .character(Some(result.name))
-                        .source(id.clone())
-                        .targets(Some(result.targets))
-                        .id(self.chat.len() + 1);
-                    self.chat.push((id, msg.clone()));
-                    _ = broadcast.send((None, api::Response::Message(msg)));
-                        
-                }
                 api::Request::Quit => _ = broadcast.send((None, api::Response::Quit { id })),
                 api::Request::Kick(id) => _ = broadcast.send((Some(id), api::Response::Shutdown)),
                 api::Request::Shutdown => break,

src/pathfinder2r_impl/mod.rs

@@ -1,4 +1,4 @@
-use crate::game::{character_sheet::*, chat_message::ChatMessage, entry::{ActionDefinition, ActionResult, DiceRoll, GameEntry}};
+use crate::game::{entry::{ActionDefinition, ActionResult, GameEntry}, character_sheet::*, chat_message::{ChatMessage, RollDialogOption}};
 use serde::Serialize;
 use tavern_macros::CharacterSheet;
 
@@ -89,20 +89,14 @@ impl Character<Entry> for Pathfinder2rCharacterSheet {
     fn use_action(&mut self, entry: &Entry, action: &ActionResult) -> ChatMessage {
         match entry {
             Entry::Weapon(_) => ChatMessage::new("Attack".to_string())
-                    .with_action(
-                        ActionDefinition::new("Attack".to_string())
-                            .with_roll(DiceRoll::new("Piercing".to_string(), 12, 1))
-                    )
-                    .with_action(
-                        ActionDefinition::new("Double".to_string())
-                            .with_roll(DiceRoll::new("Piercing".to_string(), 12, 2))
-                    ),
+                    .with_roll(RollDialogOption { name: String::from("pierce"), dice_type: 4, dice_amount: 1, constant: 0, extra: String::new(), enabled: true })
+                    .roll_target(Some(10))
+                    .with_action("damage".to_string())
+                    .with_action("double".to_string()),
             Entry::Consumable(_consumable) => if action.name == "consume" {
                 ChatMessage::new("Heal".to_string())
-                    .with_action(
-                        ActionDefinition::new("Heal".to_string())
-                            .with_roll(DiceRoll::new("Heal".to_string(), 6, 0).constant(6))
-                    )
+                    .with_roll(RollDialogOption { name: "heal".to_string(), dice_type: 6, dice_amount: 1, constant: 0, extra: String::new(), enabled: true })
+                    .with_action("heal".to_string())
             } else { todo!() },
             Entry::Spell(_spell) => todo!(),
         }
@@ -119,7 +113,7 @@ impl Character<Entry> for Pathfinder2rCharacterSheet {
             Entry::Spell(_) => v = vec![("cast", 1)],
         };
         v.iter()
-            .map(|s| ActionDefinition { name: s.0.to_string(), targets: s.1, display_name: None, source: None, rolls: None })
+            .map(|s| ActionDefinition { name: s.0.to_string(), targets: s.1 })
             .collect()
     }
 }